Skipping flaky interactive tests 🧨 #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/XL
chmouel
force-pushed
the
issue-499-flaky-unit-tests-in-ci
branch
from
5f3481d
to
35a0456
Compare
tekton-robot
added
size/S
chmouel
changed the title
Closes tektoncd#499 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
chmouel
force-pushed
the
issue-499-flaky-unit-tests-in-ci
branch
from
35a0456
to
a7e164a
Compare
tekton-robot
added
size/M
|
The following is the coverage report on pkg/.
|
This was referenced Jan 16, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping all flaky tests that does "interactive" testing, which hasn't been proven stable and arguably not supposed to be mixed with the unit tests.....
We should next move them to the e2e tests and have them working in a periodic job.
(When we have tekton on tekton CI)
Coverage is going to take a hit but sanity will be back.
Closes #499